Skip to content

Record cleanup#85

Open
DutChen18 wants to merge 3 commits intomasterfrom
record-cleanup
Open

Record cleanup#85
DutChen18 wants to merge 3 commits intomasterfrom
record-cleanup

Conversation

@DutChen18
Copy link
Copy Markdown
Member

No description provided.

@DutChen18 DutChen18 force-pushed the record-cleanup branch 2 times, most recently from 233cb75 to 5d4c2ef Compare April 3, 2026 01:04
@DutChen18
Copy link
Copy Markdown
Member Author

I would still like to add some extra functions on the record trait for stuff like selecting rows by multiple ids, inserting rows, etc...

@DutChen18 DutChen18 marked this pull request as ready for review April 4, 2026 00:52
@DutChen18 DutChen18 requested a review from BoySanic April 4, 2026 00:52
- name: Sqlx Prepare Check
run: cargo sqlx prepare --check
working-directory: ./server
run: cargo sqlx prepare --check --workspace
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this do differently from the original workflow?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's also some sql queries in the common crate now instead of just the server crate. Without --workspace it would only generate the sqlx stuff for one crate, this generates it for all crates in the workspace.

@DutChen18
Copy link
Copy Markdown
Member Author

This is broken atm because serde_urlencoded does not support arrays :notlikethis:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants